[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

Wed Nov 10 12:17:35 PST 2021

Hi Jonas,

Apologies for the non-build - I did a fetch/rebase this morning before creating the patch.  Do I need to be on a different branch re StringRef vs ConstString?  (Have seen that discussion in passing but confess I did not follow it in detail.)  Any pointers appreciated.

Re testing, I basically duplicated the test set from Lua and ran it using "ninja check-lldb-unit" and "ninja check-lldb-shell".  I'm not really conversant with your testing infrastructure.  Can you point me to something that might be suggest what I'd need to do to generate a bot?  I'll give it a shot if I have a starting point.

Also am happy to maintain the code in general and have a few folks in our project that can backstop me in case I get run over by a bus or something.  😊

Best,

Dave

________________________________
From: Jonas Devlieghere via Phabricator <reviews at reviews.llvm.org>
Sent: Wednesday, November 10, 2021 1:57:51 PM
To: David Millar; anoronha at apple.com; fallkrum at yahoo.com; kkleine at redhat.com; teemperor at gmail.com; medismail.bennani at gmail.com; tedwood at quicinc.com; jmolenda at apple.com; syaghmour at apple.com; jingham at apple.com; vsk at apple.com; boris.ulasevich at gmail.com; lldb-commits at lists.llvm.org; h.imai.833 at nitech.jp; bruce.mitchener at gmail.com; david.spickett at linaro.org; quic_sourabhs at quicinc.com; djordje.todorovic at syrmia.com; serhiy.redko at gmail.com; Liburd1994 at outlook.com
Cc: mgorny at gentoo.org
Subject: [PATCH] D111409: proposed support for Java interface to Scripting Bridge

JDevlieghere added a comment.

Hi David, this looks really comprehensive. As far as the code is concerned, it has all the parts that we'd want to support another scripting language in LLDB. That leaves us with the last remaining questions:

- Testing: having a bot that actually builds & tests this configuration.
- Maintainership: having a commitment from you (or someone else) to maintain this code.

Are you willing and able to sign up for those things?

PS: I installed Java and applied your patch on top-of-tree. Things didn't built because of the recent change to the plugin manager that now expects `StringRef`s instead of `ConstString`s. Please let me know if you've rebased the patch and I'd love to give it a try.

================
Comment at: lldb/cmake/modules/FindJavaAndSwig.cmake:13
+    find_package(Java 11.0)
+    find_package(JNI REQUIRED)
+    if(JAVA_FOUND AND SWIG_FOUND)
----------------
This can't be `REQUIRED` because that will fail the CMake configuration stage when Java isn't found which is not what you want when doing autodetection (the default). Making it required is handled at a higher level for `FindJavaAndSwig` as a whole.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111409/new/

https://reviews.llvm.org/D111409

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211110/eb75e5aa/attachment.html>