[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

[Jordan Rupprecht via Phabricator via lldb-commits]

rupprecht added a comment.

In D113449#3121070 <https://reviews.llvm.org/D113449#3121070>, @teemperor wrote:

> I actually didn't see that the patch deleted the TestCppReferenceToOuterClass test. Could you just add a `@skipIf # Crashes` or so above its `def test...` method? The test itself is still valid user code that we shouldn't crash on.

I assume you mean something like `expectedFailure`, as this should unconditionally fail.

> I left some nits and the test source probably needs to be made a bit more expressive in terms of what's its trying to test, but this can all be done later. Let's just land this to get the regression fixed.

OK, retesting real quick against trunk and submitting now. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113449/new/

https://reviews.llvm.org/D113449