[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

Some of the formatting in the Python tests seems a little off (can you run it through something like yapf <https://github.com/google/yapf>?). Other than that this LGTM with the inline comments addressed.



================
Comment at: lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py:101
     @skipUnlessDarwin
+    @skipIf(archs=no_match(['x86_64']))
     def test_launch_scripted_process_stack_frames(self):
----------------
You'll also need `skipIfOutOfTreeDebugserver` because skinny corefiles require debugserver support.


================
Comment at: lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py:119
+        scripted_process_example_relpath = 'stack_core_scripted_process.py'
+        os.environ['SKIP_SCRIPTED_PROCESS_LAUNCH'] = '1'
         self.runCmd("command script import " + os.path.join(self.getSourceDir(),
----------------
You'll want to unset this after your test so it doesn't affect another test:

```
        def cleanup():
            del os.environ["SKIP_SCRIPTED_PROCESS_LAUNCH"]
        self.addTearDownHook(cleanup)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112047/new/

https://reviews.llvm.org/D112047