[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:337
+  std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
+  if (!(name_type_mask & eFunctionNameTypeMethod))
+    return;
----------------
zequanwu wrote:
> labath wrote:
> > How did you come to pick this? I get that this is not critical functionality for your use case, but it seems rather strange to be claiming that you're looking up methods here. If you don't care what you look up exactly, then maybe you could just skip this check completely, possibly leaving a TODO to implement this in a better way. (The Symtab class has code (heuristics) which tries to classify symbols into functions, methods, etc., but I'm not sure if it actually works with breakpad symbols (them being demangled), nor am I sure that we should replicate that here.)
> I just found that name_type_mask always has `eFunctionNameTypeMethod`. 
> Removed.
This is probably the only value used by the tests, but one can definitely get other values too, for example through various arguments to the "breakpoint set" command. While a (very) brave soul could in theory try to set breakpoints and debug a live process with breakpad debug info, I think that's unlikely to happen in practice. So the usefulness of this function will probably remain limited to tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113163/new/

https://reviews.llvm.org/D113163