[Lldb-commits] [PATCH] D113533: [LLDB] Remove access check of decl in TypeSystemClang.cpp

[Raphael Isemann via Phabricator via lldb-commits]

teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.

I'm pretty sure you're trying to solve the same problem as here: D85993 <https://reviews.llvm.org/D85993>

In short: You're calling `CreateFunctionDeclaration` to create a function in a record, but you actually want to call `AddMethodToCXXRecordType` which allows passing and setting an access specifier (which is what the assert here checks). You can fix this in the PDB plugin by looking at the DeclContext and if `decl_ctx->isRecord()` -> `AddMethodToCXXRecordType` and otherwise `CreateFunctionDeclaration`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113533/new/

https://reviews.llvm.org/D113533