[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked 3 inline comments as done.
mib added inline comments.


================
Comment at: lldb/examples/python/scripted_process/stack_core_scripted_process.py:1
+import os,struct,signal
+
----------------
JDevlieghere wrote:
> This should live next to the test. I don't see a point of shipping this to users. 
Do you mean the python script or the import statement ? In both case, I don't think this we ship these to the users.


================
Comment at: lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py:124
 
-        scripted_process_example_relpath = ['..','..','..','..','examples','python','scripted_process','my_scripted_process.py']
-        self.runCmd("command script import " + os.path.join(self.getSourceDir(),
-                                                            *scripted_process_example_relpath))
+        os.environ['SKIP_SCRIPTED_PROCESS_LAUNCH'] = '1'
+        self.runCmd("command script import " + os.path.join(self.scripted_process_example_abspath,
----------------
JDevlieghere wrote:
> We should really find a better way to do this. Can you remind me why we can't pass that in the structured data? Other than for you test, I assume we rarely want a process launch for a scripted process, so maybe the default should be inverted. 
This is an environment variable used to decide whether we should launch the process right after importing the python script in lldb or leave it to the user' s discretion.

This is also used to launch the process from the script interpreter using the SBAPI, to test launching the scripted process in both a synchronous and asynchronous mode.

It can also come quite handy for debugging and troubleshooting scripted processes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112047/new/

https://reviews.llvm.org/D112047