[Lldb-commits] [lldb] 553a872 - [LLDB] Adjust DumpDataExtractorTest.Formats for Windows

Muhammad Omair Javaid via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 3 20:48:51 PDT 2021


Author: Muhammad Omair Javaid
Date: 2021-11-04T08:48:26+05:00
New Revision: 553a87246510632b60d8d87913d8e4d5ddc86529

URL: https://github.com/llvm/llvm-project/commit/553a87246510632b60d8d87913d8e4d5ddc86529
DIFF: https://github.com/llvm/llvm-project/commit/553a87246510632b60d8d87913d8e4d5ddc86529.diff

LOG: [LLDB] Adjust DumpDataExtractorTest.Formats for Windows

Floating point results mismtach between Visual stdio 2019 and previous
versions. This adjusts macro accordingly.

Added: 
    

Modified: 
    lldb/unittests/Core/DumpDataExtractorTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Core/DumpDataExtractorTest.cpp b/lldb/unittests/Core/DumpDataExtractorTest.cpp
index f76014aa938c..f229dacb6e6f 100644
--- a/lldb/unittests/Core/DumpDataExtractorTest.cpp
+++ b/lldb/unittests/Core/DumpDataExtractorTest.cpp
@@ -187,7 +187,7 @@ TEST(DumpDataExtractorTest, Formats) {
   // Some normal numbers.
   TestDump(std::vector<uint16_t>{0b0100001001001000},
            lldb::Format::eFormatVectorOfFloat16,
-#ifdef _WIN32
+#if defined(_MSC_VER) && _MSC_VER < 1920
            // FIXME: This should print the same on all platforms.
            "{3.14063}");
 #else


        


More information about the lldb-commits mailing list