[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

[Lawrence D'Anna via Phabricator via lldb-commits]

lawrence_danna created this revision.
lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham, stella.stamenova.
lawrence_danna requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Followup to https://reviews.llvm.org/D112988

Sorry, I broke this test.   The test was verifying the bad behavior
of --source-quietly that the previous change fixed -- namely that
it still echos the initial list of startup commands while
sourcing them.

Updated the test to verify that --source-quietly is quiet, rather than
loud.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113047

Files:
  lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
  lldb/test/Shell/Settings/TestEchoCommands.test


Index: lldb/test/Shell/Settings/TestEchoCommands.test
===================================================================
--- lldb/test/Shell/Settings/TestEchoCommands.test
+++ lldb/test/Shell/Settings/TestEchoCommands.test
@@ -1,4 +1,4 @@
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands true'  -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsAll.out
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands false' -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNoComments.out
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false'         -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNone.out
-# RUN: %lldb -x -b --source-quietly                                          -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsQuiet.out
+# RUN: ( echo start ; %lldb -x -b --source-quietly -s %S/Inputs/EchoCommandsTest.in ; echo done )             | FileCheck  %S/Inputs/EchoCommandsQuiet.out
Index: lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
===================================================================
--- lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
+++ lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
@@ -1,2 +1,4 @@
-# CHECK: (lldb) command source -s 1 {{.*\n}}
-# CHECK-NEXT: (lldb) command source -s 1 {{.*\n}}
+CHECK: start
+CHECK-NOT: source
+CHECK-NOT: lldb
+CHECK-NEXT: done


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113047.384208.patch
Type: text/x-patch
Size: 1444 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211102/80b00821/attachment.bin>