[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

Lawrence D'Anna via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 2 10:53:22 PDT 2021


lawrence_danna added a comment.

In D112988#3103574 <https://reviews.llvm.org/D112988#3103574>, @jingham wrote:

> Ha!  It was apparently so easy to add the test that it wasn't noticeable (at least by me!).
>
> This isn't directly relevant to your patch, since this wasn't behavior you changed, but it seems weird to me to suppress the commands but print their output?  Is that really the behavior we want for -Q?

I hadn't actually thought about it, as what i care about is getting `lldb -Q -o 'script print(...)' ` to work without any extra output, but now that you mention it the behavior here is inconsistent.       For sourcing files, all output is suppressed, but for onelines only echo is suppressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112988/new/

https://reviews.llvm.org/D112988



More information about the lldb-commits mailing list