[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map
Xu Jun via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Oct 29 23:23:55 PDT 2021
xujuntwt95329 marked 2 inline comments as done.
xujuntwt95329 added a comment.
Hi, @aprantl
I've submitted a NFC patch here:
https://reviews.llvm.org/D112863
Seems that patch can't build by CI because it is based on this patch. In my understanding we need to merge this patch firstly and rebase that NFC patch to let CI work, right?
Please let me know if I misunderstand the workflow.
Thanks a lot!
================
Comment at: lldb/source/Target/PathMappingList.cpp:33
// nomalized path pairs to ensure things match up.
ConstString NormalizePath(ConstString path) {
// If we use "path" to construct a FileSpec, it will normalize the path for
----------------
aprantl wrote:
> Why does this take a ConstString argument if it immediately calls GetStringRef on it?
> Could you change this to take a StringRef here or in a follow-up NFC commit?
I've submitted a separate NFC patch:
https://reviews.llvm.org/D112863
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112439/new/
https://reviews.llvm.org/D112439
More information about the lldb-commits
mailing list