[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere requested changes to this revision.
JDevlieghere added inline comments.
This revision now requires changes to proceed.


================
Comment at: lldb/include/lldb/Utility/MemoryTagMap.h:12
+
+#include "lldb/Target/MemoryTagManager.h"
+#include "lldb/lldb-private.h"
----------------
I found Utility an odd place for this class, but it certainly cannot depend on Target. This will introduce a cyclic dependency.


================
Comment at: lldb/include/lldb/Utility/MemoryTagMap.h:19-22
+// MemoryTagMap provides a way to give a sparse read result
+// when reading memory tags for a range. This is useful when
+// you want to annotate some large memory dump that might include
+// tagged memory but you don't know that it is all tagged.
----------------
These should be doxygen-style comments (which will be attached to the class below if you remove the newline). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112825/new/

https://reviews.llvm.org/D112825