[Lldb-commits] [lldb] ac73f56 - [lldb] Remove forgotten FIXME on CPlusPlus formatters

[Raphael Isemann via lldb-commits]

Author: Luís Ferreira
Date: 2021-10-29T11:32:40+02:00
New Revision: ac73f567cffb663712e937051b0e81a82488698b

URL: https://github.com/llvm/llvm-project/commit/ac73f567cffb663712e937051b0e81a82488698b
DIFF: https://github.com/llvm/llvm-project/commit/ac73f567cffb663712e937051b0e81a82488698b.diff

LOG: [lldb] Remove forgotten FIXME on CPlusPlus formatters

The patch [1] introduced this FIXME but ended up not being removed when fixed.

[1]: https://github.com/llvm/llvm-project/commit/f68df12fb039d5177e34f4541fa242b891949db6

Signed-off-by: Luís Ferreira <contact at lsferreira.net>

Reviewed By: teemperor

Differential Revision: https://reviews.llvm.org/D112586

Added: 
    

Modified: 
    lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp b/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
index 875706edd77e..626c5a5a8282 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
@@ -1014,8 +1014,6 @@ static void LoadSystemFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
       .SetShowMembersOneLiner(false)
       .SetHideItemNames(false);
 
-  // FIXME because of a bug in the FormattersContainer we need to add a summary
-  // for both X* and const X* (<rdar://problem/12717717>)
   AddCXXSummary(
       cpp_category_sp, lldb_private::formatters::Char8StringSummaryProvider,
       "char8_t * summary provider", ConstString("char8_t *"), string_flags);