[Lldb-commits] [PATCH] D112747: Restore process events after a launch that stopped at the entry point
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Oct 28 16:23:48 PDT 2021
jingham added inline comments.
================
Comment at: lldb/test/API/functionalities/launch_stop_at_entry/TestStopAtEntry.py:21
+ # The port used by debugserver.
+ PORT = 54637
+
----------------
jingham wrote:
> clayborg wrote:
> > This hard coded port worries me for buildbot flakiness. Do other tests do this?
> The test I copied it from does...
That is "TestPlatformSDK.py". I didn't centralize that logic because the two uses were different, and the implementation is not very many lines. If we see flakiness in either of these tests we can centralize this logic and handle the port fetching better. But I'd rather not do that as part of this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112747/new/
https://reviews.llvm.org/D112747
More information about the lldb-commits
mailing list