[Lldb-commits] [PATCH] D112708: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays

Thu Oct 28 07:05:05 PDT 2021

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

In D112708#3093318 <https://reviews.llvm.org/D112708#3093318>, @labath wrote:

> In D112708#3093252 <https://reviews.llvm.org/D112708#3093252>, @teemperor wrote:
>
>> LGTM, could you also extend a non-unit test to test the change within the whole FormatManager/etc. setup? I think `TestDataFormatterAdv.py` already has a very similar section about ignoring cv on types.
>
> I've added a simple check to that test. I didn't want to go overboard, as I already have an made an exhaustive test in the follow-up patch.

Fair, LGTM then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112708/new/

https://reviews.llvm.org/D112708