[Lldb-commits] [PATCH] D112708: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays

[Raphael Isemann via Phabricator via lldb-commits]

teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.

LGTM, could you also extend a non-unit test to test the change within the whole FormatManager/etc. setup? I think `TestDataFormatterAdv.py` already has a very similar section about ignoring cv on types.



================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4243
+               ast->getAsConstantArrayType(qual_type)) {
+    arr->getElementType();
+    qual_type = ast->getConstantArrayType(
----------------
?


================
Comment at: lldb/unittests/Symbol/TestTypeSystemClang.cpp:919
+  EXPECT_EQ(bool_, cv_bool.GetFullyUnqualifiedType());
+  EXPECT_EQ(bool_.GetArrayType(47),
+            cv_bool.GetArrayType(47).GetFullyUnqualifiedType());
----------------
My head has a hard time parsing what those asserts do or test. Maybe add some summary above or something similar?
```
lang=c++
// unqualified(const volatile bool[47]) -> bool[47]
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112708/new/

https://reviews.llvm.org/D112708