[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

LGTM, thanks.

On a more general note: I wish we would just kill off inline tests instead of trying to make them usable. But I think that's a discussion for the mailing lists...



================
Comment at: lldb/test/API/test_utils/TestInlineTest.py:10
+
+    def test(self):
+        filename = self.getBuildArtifact("test_file.cpp")
----------------
nit: maybe give this a more unique name + a doc string.


================
Comment at: lldb/test/API/test_utils/TestInlineTest.py:10
+
+    def test(self):
+        filename = self.getBuildArtifact("test_file.cpp")
----------------
teemperor wrote:
> nit: maybe give this a more unique name + a doc string.
Also I think this should be a NO_DEBUG_INFO_TESTCASE ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112706/new/

https://reviews.llvm.org/D112706