[Lldb-commits] [PATCH] D112629: [lldb] [Host/Socket] Make DecodeHostAndPort() return a dedicated struct

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 27 23:45:19 PDT 2021


labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Host/common/Socket.cpp:198-199
   } else {
     // If this was unsuccessful, then check if it's simply a signed 32-bit
     // integer, representing a port with an empty host.
+    if (to_integer(host_and_port, ret.port, 10))
----------------
I guess this isn't true anymore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112629/new/

https://reviews.llvm.org/D112629



More information about the lldb-commits mailing list