[Lldb-commits] [PATCH] D112495: [lldb] [Host/ConnectionFileDescriptor] Refactor to improve code reuse

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

Looking at the test backtrace, it seems that we couldn't connect to debugserver:

  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/commands/platform/sdk/TestPlatformSDK.py", line 113, in test_macos_sdk
    self.assertTrue(connected, "could not connect to debugserver")

I checked the `SBCommandReturnObject.GetError` output, which says `Failed to connect port`. The only occurence for this error is in :

  lldb/source/Host/common/TCPSocket.cpp
  183:  error.SetErrorString("error: Failed to connect port");

I reverted the patch to fix GreenDragon, I'll try to investigate more tomorrow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112495/new/

https://reviews.llvm.org/D112495