[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

walter erquinigo via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 27 11:22:24 PDT 2021


wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.

Just fix that last thing and I'll land your patch :) Thanks



================
Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:318
 
-class StdMapSynthProvider:
+class StdSetOrMapSynthProvider:
 
----------------
wallace wrote:
> Make a comment above like
> 
>   '''
>   Set and Map have the same underlying data structure, therefore we can use exactly the same implementation for the formatter.
>   '''
actual python documentation uses ''' for comments, not #


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112537/new/

https://reviews.llvm.org/D112537



More information about the lldb-commits mailing list