[Lldb-commits] [PATCH] D112457: Modernize and simplify HostInfo::GetOSKernelDescription

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/include/lldb/Host/posix/HostInfoPosix.h:25
   static bool GetHostname(std::string &s);
+  static llvm::Optional<std::string> GetOSKernelDescription();
 
----------------
Ok, I must be missing something but I don't see the implementation of this in this patch.


================
Comment at: lldb/source/Target/Platform.cpp:495
 
 bool Platform::GetOSKernelDescription(std::string &s) {
+  if (IsHost()) {
----------------
I'd also change this prototype while at it ;-).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112457/new/

https://reviews.llvm.org/D112457