[Lldb-commits] [PATCH] D112457: Modernize and simplify HostInfo::GetOSKernelDescription

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: mgorny, teemperor.
Herald added a subscriber: emaste.
labath requested review of this revision.
Herald added a project: LLDB.

Replace bool+by-ref argument with llvm::Optional, and move the common
implementation into HostInfoPOSIX. Based on my (simple) experiment,
the uname and the sysctl approach return the same value on MacOS, so
there's no need for a mac-specific implementation of this functionality.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112457

Files:
  lldb/include/lldb/Host/freebsd/HostInfoFreeBSD.h
  lldb/include/lldb/Host/linux/HostInfoLinux.h
  lldb/include/lldb/Host/macosx/HostInfoMacOSX.h
  lldb/include/lldb/Host/netbsd/HostInfoNetBSD.h
  lldb/include/lldb/Host/openbsd/HostInfoOpenBSD.h
  lldb/include/lldb/Host/posix/HostInfoPosix.h
  lldb/include/lldb/Host/windows/HostInfoWindows.h
  lldb/source/Host/freebsd/HostInfoFreeBSD.cpp
  lldb/source/Host/linux/HostInfoLinux.cpp
  lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm
  lldb/source/Host/netbsd/HostInfoNetBSD.cpp
  lldb/source/Host/openbsd/HostInfoOpenBSD.cpp
  lldb/source/Host/windows/HostInfoWindows.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
  lldb/source/Target/Platform.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112457.381996.patch
Type: text/x-patch
Size: 8699 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211025/f611c06c/attachment-0001.bin>