[Lldb-commits] [PATCH] D111964: [lldb] [lldb-gdbserver] Unify listen/connect code to use ConnectionFileDescriptor

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 25 03:47:28 PDT 2021


mgorny updated this revision to Diff 381918.
mgorny added a comment.

Remove error handling from URI mapping to make the code simpler. In the end, the only possible error here was '--reverse-connect without valid host:port' and we can just treat that as UNIX connect for symmetry with non-reverse-connect mode.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111964/new/

https://reviews.llvm.org/D111964

Files:
  lldb/include/lldb/Host/posix/ConnectionFileDescriptorPosix.h
  lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
  lldb/test/API/tools/lldb-server/TestPtyServer.py
  lldb/tools/lldb-server/lldb-gdbserver.cpp
  lldb/unittests/Process/gdb-remote/CMakeLists.txt
  lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationServerLLGSTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111964.381918.patch
Type: text/x-patch
Size: 32717 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211025/b30f7b25/attachment-0001.bin>


More information about the lldb-commits mailing list