[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 25 01:00:11 PDT 2021


labath added a comment.

In D112212#3083194 <https://reviews.llvm.org/D112212#3083194>, @teemperor wrote:

> Given that `shlex.join` is only used for making the diagnostics copy-pastable into the terminal, we could probably get away by just making it use the normal string conversion of list or something like `" ".join(...)`. I don't think we have anyone that really debugs tests in Python2 builds.

Yeah, I was thinking the same thing, but given that Oct 26th is like tomorrow, I think I can just wait a couple of days.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112212/new/

https://reviews.llvm.org/D112212



More information about the lldb-commits mailing list