[Lldb-commits] [PATCH] D112379: [lldb][NFC] Modernize for-loops in ModuleList

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Oct 24 07:29:50 PDT 2021


teemperor added a comment.

Straightforward but looking for a second set of eyes



================
Comment at: lldb/source/Core/ModuleList.cpp:204
+bool ModuleList::AppendIfNeeded(const ModuleSP &new_module, bool notify) {
+  if (new_module) {
     std::lock_guard<std::recursive_mutex> guard(m_modules_mutex);
----------------
I'll make this early-exit as a follow-up (along with some other functions that could do the same).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112379/new/

https://reviews.llvm.org/D112379



More information about the lldb-commits mailing list