[Lldb-commits] [lldb] 42e4959 - [lldb/Formatters] Remove space from vector type string summaries (NFCI)

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 22 12:19:01 PDT 2021


Author: Med Ismail Bennani
Date: 2021-10-22T21:18:54+02:00
New Revision: 42e4959253e0045a70ff9d8dcb664ce38434e302

URL: https://github.com/llvm/llvm-project/commit/42e4959253e0045a70ff9d8dcb664ce38434e302
DIFF: https://github.com/llvm/llvm-project/commit/42e4959253e0045a70ff9d8dcb664ce38434e302.diff

LOG: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

This patch changes the string summaries for vector types by removing the
space between the type and the bracket, conforming to 277623f4d5a6.

This should also fix TestCompactVectors failure.

Differential Revision: https://reviews.llvm.org/D112340

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>

Added: 
    

Modified: 
    lldb/source/DataFormatters/FormatManager.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/DataFormatters/FormatManager.cpp b/lldb/source/DataFormatters/FormatManager.cpp
index 92171b67fe96..cda1ae60d857 100644
--- a/lldb/source/DataFormatters/FormatManager.cpp
+++ b/lldb/source/DataFormatters/FormatManager.cpp
@@ -773,14 +773,11 @@ void FormatManager::LoadVectorFormatters() {
 
   AddStringSummary(vectors_category_sp, "${var.uint128}",
                    ConstString("builtin_type_vec128"), vector_flags);
-
-  // FIXME: These probably need the space removed, or made optional - but are
-  // they even tested?
-  AddStringSummary(vectors_category_sp, "", ConstString("float [4]"),
+  AddStringSummary(vectors_category_sp, "", ConstString("float[4]"),
                    vector_flags);
-  AddStringSummary(vectors_category_sp, "", ConstString("int32_t [4]"),
+  AddStringSummary(vectors_category_sp, "", ConstString("int32_t[4]"),
                    vector_flags);
-  AddStringSummary(vectors_category_sp, "", ConstString("int16_t [8]"),
+  AddStringSummary(vectors_category_sp, "", ConstString("int16_t[8]"),
                    vector_flags);
   AddStringSummary(vectors_category_sp, "", ConstString("vDouble"),
                    vector_flags);


        


More information about the lldb-commits mailing list