[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 22 12:16:30 PDT 2021


mib created this revision.
mib added a reviewer: dblaikie.
mib added a project: LLDB.
Herald added a subscriber: JDevlieghere.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.

This patch changes the string summaries for vector types by removing the
space between the type and the bracket, conforming to 277623f4d5a6 <https://reviews.llvm.org/rG277623f4d5a672d707390e2c3eaf30a9eb4b075c>.

This should also fix TestCompactVectors failure.

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112340

Files:
  lldb/source/DataFormatters/FormatManager.cpp


Index: lldb/source/DataFormatters/FormatManager.cpp
===================================================================
--- lldb/source/DataFormatters/FormatManager.cpp
+++ lldb/source/DataFormatters/FormatManager.cpp
@@ -776,11 +776,11 @@
 
   // FIXME: These probably need the space removed, or made optional - but are
   // they even tested?
-  AddStringSummary(vectors_category_sp, "", ConstString("float [4]"),
+  AddStringSummary(vectors_category_sp, "", ConstString("float[4]"),
                    vector_flags);
-  AddStringSummary(vectors_category_sp, "", ConstString("int32_t [4]"),
+  AddStringSummary(vectors_category_sp, "", ConstString("int32_t[4]"),
                    vector_flags);
-  AddStringSummary(vectors_category_sp, "", ConstString("int16_t [8]"),
+  AddStringSummary(vectors_category_sp, "", ConstString("int16_t[8]"),
                    vector_flags);
   AddStringSummary(vectors_category_sp, "", ConstString("vDouble"),
                    vector_flags);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112340.381628.patch
Type: text/x-patch
Size: 985 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211022/54ea412e/attachment.bin>


More information about the lldb-commits mailing list