[Lldb-commits] [PATCH] D112325: [lldb] Pass the target triple to the compiler when determining the DWARF version

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

Some nits but otherwise LGTM



================
Comment at: lldb/packages/Python/lldbsuite/test/builders/builder.py:26
+        """Returns the triple for the given architecture or an empty string."""
+        return ""
+
----------------
Maybe return `None`? Then the calling code crashes if it doesn't handle the value instead of silently picking the next arg as some bogus triple value.


================
Comment at: lldb/packages/Python/lldbsuite/test/builders/darwin.py:60
+        vendor, os, version, env = get_triple()
+        if arch is None or vendor is None or os is None or version is None or env is None:
+            return ""
----------------

```
lang=python
values = [arch, vendor, os, version, env]
if None in values:
    return ""
return '-'.join(values)
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112325/new/

https://reviews.llvm.org/D112325