[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I agree with what Raphael said.

Here's my attempt at a test case. Let me know what you think.



================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1422
+    def runBuildCommands(self, commands):
+        for cmd in commands:
+            self.trace(shlex.join(cmd))
----------------
DavidSpickett wrote:
> Is this ever going to have more than one command to run?
> 
> Seems like the source is the function above that puts a single command into a list.
Well.. the general idea of the builder plugins was that they could build the test executable in any way they see fit, but I don't reallisticaly see it using anything other than makefiles any time soon. The whole builder module idea is a bit flawed, because it keys everything off of the host platform, but most of the customizations need to happen because of target platform specifics. So, I guess I'll just drop the multiple command mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112212/new/

https://reviews.llvm.org/D112212