[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

In D111686#3079352 <https://reviews.llvm.org/D111686#3079352>, @teemperor wrote:

> In D111686#3079248 <https://reviews.llvm.org/D111686#3079248>, @clayborg wrote:
>
>> So there is a buildbot failure due to an expression which succeeds, but because the "expression" command options don't apply cleanly to the expression result the "expression" command fails. Question: do we want "expressionEvaluation" to truly track expression evaluation failures, or just track the "expression" command success and fails? I updated this patch to track expression failures only by modifying the Target::EvaluateExpression(), so if this succeeds and "expr" command fails, we consider the expression a success right now.
>
> I have to look into this but could we skip that test in the meantime?
>
> There is also another failure that looks like it's caused by some accidental change (see inline)''

I will check in a fix in a few minutes for my buildbot issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111686/new/

https://reviews.llvm.org/D111686