[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

[Ben Jackson via Phabricator via lldb-commits]

puremourning added a comment.

In D112222#3078896 <https://reviews.llvm.org/D112222#3078896>, @shafik wrote:

> It looks good to me but can we verify it behaves nicely with undefined behavior cases e.g.:
>
>   std::string s = "Hellooooooooooooooo ";
>   std::string_view sv = s + "World\n";

Will add some cases, sure.

> and a case like the one that was fixed in D108228 <https://reviews.llvm.org/D108228>

Thanks for the pointer! (no pun intended). I will apply the same change/mitigattion to my new code.

> I am not expecting any surprises since you are using the underlying string formatter but worth checking.

yes, certainly is, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112222/new/

https://reviews.llvm.org/D112222