[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

Thu Oct 21 08:08:08 PDT 2021

teemperor added a comment.

In D112222#3077988 <https://reviews.llvm.org/D112222#3077988>, @puremourning wrote:

> I'm happy to revert/split out the change for empty strings, as this is perhaps contentious (and not exactly minimal for this patch).

I would actually prefer if we could split this into a separate change :) (Sorry!)

> Also, I'm only implementing libcxx (for now). We can follow up with libstdc++ in another patch if this is accepted.

Sounds good to me.

> This is my first lldb patch, so apologies if I did something out of ordinary.

Nope, I think this is actually looking pretty good. I just have a few nits that I'll try get around today/tomorrow.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112222/new/

https://reviews.llvm.org/D112222