[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions
Michał Górny via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Oct 21 05:28:48 PDT 2021
mgorny updated this revision to Diff 381226.
mgorny added a comment.
This revision is now accepted and ready to land.
Ok, this turned out to be a little bit harder than I anticipated — in particular I needed to add a copy constructor and assignment operator.
@labath, do you think it's fine or should I revert to non-`char` version?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110535/new/
https://reviews.llvm.org/D110535
Files:
lldb/source/Host/common/File.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
llvm/include/llvm/ADT/StringExtras.h
llvm/lib/IR/DataLayout.cpp
llvm/unittests/ADT/StringExtrasTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110535.381226.patch
Type: text/x-patch
Size: 11329 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211021/8d64e593/attachment.bin>
More information about the lldb-commits
mailing list