[Lldb-commits] [PATCH] D112167: [lldb/Plugins] Refactor ScriptedThread register context creation

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 20 13:53:27 PDT 2021


shafik added inline comments.


================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:186
 void ScriptedThread::RefreshStateAfterStop() {
-  // TODO: Implement
-  if (m_reg_context_sp)
-    m_reg_context_sp->InvalidateAllRegisters();
+  GetRegisterContext()->InvalidateIfNeeded(false /*=force*/);
 }
----------------
It should be `/*force=*/false`


See [clang-tidy - bugprone-argument-comment](https://clang.llvm.org/extra/clang-tidy/checks/bugprone-argument-comment.html)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112167/new/

https://reviews.llvm.org/D112167



More information about the lldb-commits mailing list