[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

[David Blaikie via Phabricator via lldb-commits]

dblaikie added a comment.
Herald added a subscriber: JDevlieghere.

Looks like this test, when it was introduced/substantially refactored in D9426 <https://reviews.llvm.org/D9426> - what was missing compared to all the other tests updated to run on linux, was the Makefile change to use libc++, so it was failing in places where libc++ wasn't the default. Fix that and it seems to pass for me, at least. Not sure if we need to keep some of the other expected failures (on some particular subset of clang, etc?)

Also there's a few other of these pretty printer tests that are still classified as skip-on-gcc, though at least some have been reclassified as passing-on-gcc in changes since D9426 <https://reviews.llvm.org/D9426>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112163/new/

https://reviews.llvm.org/D112163