[Lldb-commits] [PATCH] D112058: [lldb/DWARF] Ignore debug info pointing to the low addresses

Wed Oct 20 01:57:22 PDT 2021

labath added a comment.

In D112058#3073451 <https://reviews.llvm.org/D112058#3073451>, @clayborg wrote:

> Looks good. Do we need a follow up patch to avoid creating functions that should have been stripped?

I'm not entirely sure what you mean by that. Are you referring to the fact that `SymbolFileDWARF::ResolveFunction` creates an `lldb_private::Function`, which it does not add the to result SymbolContextList (instead of not creating the object in the first place?

If yes, then that sounds like a good idea. I don't know if this has more user-facing implications, but I was definitely puzzled by the fact that the stripped function still showed up in "image dump ast". I'll see what can be done about that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112058/new/

https://reviews.llvm.org/D112058