[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha added inline comments.


================
Comment at: lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py:269
         self.expect(side_effect.bp_loc, exe=False,
-                patterns=["1.* where = .*main .* resolved, hit count = 1"])
+                patterns=["1.* where = .*main .* resolved,( hardware,)? hit count = 1"])
 
----------------
jingham wrote:
> Why didn't you change this one to use your new function?
`check_breakpoint` checks the correctness of a breakpoint and its locations, whereas this test seems to be checking that `side_effect` is correctly updated inside the breakpoint command script.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111899/new/

https://reviews.llvm.org/D111899