[Lldb-commits] [PATCH] D112107: [lldb/Plugins] Make `ScriptedInterface::CreatePluginObject` more generic

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 19 16:17:23 PDT 2021


mib created this revision.
mib added a reviewer: JDevlieghere.
mib added a project: LLDB.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.

This patch refactors the `ScriptedInterface::CreatePluginObject` method
and all its virtual implementations to use a `StructuredData::ObjectSP`
instead of a `StructuredData::DictionarySP` argument.

This is less restrictive and makes calls to `StructuredData::ParseJSON`
seemless.

This patch also updates the `ScriptedProcessInfo` class to conform to this.

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112107

Files:
  lldb/include/lldb/Interpreter/ScriptedInterface.h
  lldb/include/lldb/Interpreter/ScriptedProcessInterface.h
  lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp
  lldb/source/Plugins/Process/scripted/ScriptedProcess.h
  lldb/source/Plugins/Process/scripted/ScriptedThread.cpp
  lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp
  lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.h
  lldb/source/Plugins/ScriptInterpreter/Python/ScriptedThreadPythonInterface.cpp
  lldb/source/Plugins/ScriptInterpreter/Python/ScriptedThreadPythonInterface.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112107.380808.patch
Type: text/x-patch
Size: 6108 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211019/a71808a1/attachment.bin>


More information about the lldb-commits mailing list