[Lldb-commits] [PATCH] D112058: [lldb/DWARF] Ignore debug info pointing to the low addresses

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 19 09:50:48 PDT 2021


labath added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:472
+  InitializeFirstCodeAddress(*m_objfile_sp->GetModule()->GetSectionList());
+  if (m_first_code_address == LLDB_INVALID_ADDRESS)
+    m_first_code_address = 0;
----------------
shafik wrote:
> It would be nice to wrap this up into `InitializeFirstCodeAddress(...)` it could be done by making iterating over the section list a lambda and then checking after that or splitting it into a helper etc
Yeah I was wondering about that myself. I've created a new function for that now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112058/new/

https://reviews.llvm.org/D112058



More information about the lldb-commits mailing list