[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Oct 19 09:46:52 PDT 2021
labath added inline comments.
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:646
+ bpno,
+ expected_locations = -1,
+ expected_hit_count = -1,
----------------
`None` would be more pythonic
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:663-664
+ if(expected_locations > -1):
+ test.assertTrue(expected_locations == bkpt.GetNumLocations(),
+ "Expecting {} locations, got {}.".format(expected_locations, bkpt.GetNumLocations()))
+
----------------
If you replace `assertTrue(foo == bar)` with `assertEquals(foo, bar)` then you get the failure message for free.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111899/new/
https://reviews.llvm.org/D111899
More information about the lldb-commits
mailing list