[Lldb-commits] [PATCH] D112058: [lldb/DWARF] Ignore debug info pointing to the low addresses

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: clayborg, aadsm.
labath requested review of this revision.
Herald added a project: LLDB.

specifically, ignore addresses that point before the first code section.

This resurrects D87172 <https://reviews.llvm.org/D87172> with several notable changes:

- it fixes a bug where the early exits in InitializeObject left m_first_code_address "initialized" to LLDB_INVALID_ADDRESS (0xfff..f), which caused _everything_ to be ignored.
- it extends the line table fix to function parsing as well, where it replaces a similar check which was checking the executable permissions of the section. This was insufficient because some position-independent elf executables can have an executable segment mapped at file address zero. (What makes this fix different is that it checks for the executable-ness of the sections contained within that segment, and those will not be at address zero.)
- It uses a different test case, with an elf file with near-zero addresses, and checks for both line table and function parsing.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112058

Files:
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
  lldb/test/Shell/SymbolFile/DWARF/lit.local.cfg
  lldb/test/Shell/SymbolFile/DWARF/x86/dead-code-filtering.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112058.380611.patch
Type: text/x-patch
Size: 9613 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211019/a8ab9def/attachment.bin>