[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/include/lldb/Host/Terminal.h:21
 public:
+  struct Data;
+
----------------
mgorny wrote:
> labath wrote:
> > Move this into the protected section
> If I do that, I can't use it from `TerminalState`.
I see. I was expecting that TerminalState was a friend or something. Given the new setup I think it would make sense to make it a friend so that it can use Get/SetData instead of raw tc[gs]etattr calls (and hopefully avoid some ifdefs).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111890/new/

https://reviews.llvm.org/D111890