[Lldb-commits] [PATCH] D111981: [lldb] Fix missing dependency on libc++ from LLDB test suite on non-Darwin platforms

Mon Oct 18 13:22:50 PDT 2021

dblaikie added a comment.

So this'll add the right test dependency, if the libcxx project is enabled in the build? (& if the build hasn't enabled libcxx, the tests will run, but against the system compiler - and if that system compiler happens to default to libc++ ( https://github.com/llvm/llvm-project/blob/e9e4fc0fd3e0780207c731a1f2b8f6aacd24e8f8/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/list/TestDataFormatterLibcxxList.py#L49 )) that should remove the "different results if you run `ninja check-lldb` before or after `ninja check-libcxx`" issue? Great, thanks!

Hmm, it doesn't appear to be working for me, running this (in a clean build directly, synced to 74c4d44d47b282769f6584153e9b433e8e5fa671 <https://reviews.llvm.org/rG74c4d44d47b282769f6584153e9b433e8e5fa671> which includes 366fb539485a9753e4a8167fe5140bf4fb00a098 <https://reviews.llvm.org/rG366fb539485a9753e4a8167fe5140bf4fb00a098> (& validated by inspecting `lldb/test/CMakeLists.txt`) still shows the tests as unsupported:

  CC=clang CXX=clang++ cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_WERROR=true -DLLVM_ENABLE_PROJECTS='llvm;clang;clang-tools-extra;lld;lldb;cross-project-tests' -DLLVM_ENABLE_RUNTIMES='compiler-rt;libcxx;libcxxabi;libunwind' -DCMAKE_INSTALL_PREFIX=$HOME/install ~/dev/llvm/src/llvm
  ninja check-lldb-api-functionalities-data-formatter-data-formatter-stl-libcxx

And then running `ninja cxx` and the same check again:

  ********************
  FAIL: lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/set/TestDataFormatterLibcxxSet.py (23 of 23)
  ******************** TEST 'lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/set/TestDataFormatterLibcxxSet.py' FAILED ********************
  Script:
  --
  /usr/bin/python3.9 /usr/local/google/home/blaikie/dev/llvm/src/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env ARCHIVER=/usr/bin/ar --env OBJCOPY=/usr/bin/objcopy --env LLVM_LIBS_DIR=/usr/local/google/home/blaikie/dev/llvm/build/release/./lib --arch x86_64 --build-dir /usr/local/google/home/blaikie/dev/llvm/build/release/lldb-test-build.noindex --lldb-module-cache-dir /usr/local/google/home/blaikie/dev/llvm/build/release/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /usr/local/google/home/blaikie/dev/llvm/build/release/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /usr/local/google/home/blaikie/dev/llvm/build/release/./bin/lldb --compiler /usr/local/google/home/blaikie/dev/llvm/build/release/./bin/clang --dsymutil /usr/local/google/home/blaikie/dev/llvm/build/release/./bin/dsymutil --llvm-tools-dir /usr/local/google/home/blaikie/dev/llvm/build/release/./bin --lldb-libs-dir /usr/local/google/home/blaikie/dev/llvm/build/release/./lib /usr/local/google/home/blaikie/dev/llvm/src/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/set -p TestDataFormatterLibcxxSet.py
  --
  Exit Code: 1

  Command Output (stdout):
  --
  lldb version 14.0.0 (git at github.com:llvm/llvm-project.git revision 74c4d44d47b282769f6584153e9b433e8e5fa671)
    clang revision 74c4d44d47b282769f6584153e9b433e8e5fa671
    llvm revision 74c4d44d47b282769f6584153e9b433e8e5fa671
  Skipping the following test categories: ['dsym', 'gmodules', 'debugserver', 'objc']

  --
  Command Output (stderr):
  --
  UNSUPPORTED: LLDB (/usr/local/google/home/blaikie/dev/llvm/build/release/bin/clang-x86_64) :: test_ref_and_ptr_dsym (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase) (test case does not fall in any category of interest for this run) 
  FAIL: LLDB (/usr/local/google/home/blaikie/dev/llvm/build/release/bin/clang-x86_64) :: test_ref_and_ptr_dwarf (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase)
  FAIL: LLDB (/usr/local/google/home/blaikie/dev/llvm/build/release/bin/clang-x86_64) :: test_ref_and_ptr_dwo (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase)
  UNSUPPORTED: LLDB (/usr/local/google/home/blaikie/dev/llvm/build/release/bin/clang-x86_64) :: test_ref_and_ptr_gmodules (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase) (test case does not fall in any category of interest for this run) 
  UNSUPPORTED: LLDB (/usr/local/google/home/blaikie/dev/llvm/build/release/bin/clang-x86_64) :: test_with_run_command_dsym (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase) (test case does not fall in any category of interest for this run) 
  FAIL: LLDB (/usr/local/google/home/blaikie/dev/llvm/build/release/bin/clang-x86_64) :: test_with_run_command_dwarf (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase)
  FAIL: LLDB (/usr/local/google/home/blaikie/dev/llvm/build/release/bin/clang-x86_64) :: test_with_run_command_dwo (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase)
  UNSUPPORTED: LLDB (/usr/local/google/home/blaikie/dev/llvm/build/release/bin/clang-x86_64) :: test_with_run_command_gmodules (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase) (test case does not fall in any category of interest for this run) 
  ======================================================================
  FAIL: test_ref_and_ptr_dwarf (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase)
     Test that the data formatters work on ref and ptr.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1823, in test_method
      return attrvalue(self)
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/set/TestDataFormatterLibcxxSet.py", line 128, in test_ref_and_ptr
      (self.target, process, _, bkpt) = lldbutil.run_to_source_breakpoint(
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/packages/Python/lldbsuite/test/lldbutil.py", line 970, in run_to_source_breakpoint
      return run_to_breakpoint_do_run(test, target, breakpoint, launch_info,
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/packages/Python/lldbsuite/test/lldbutil.py", line 892, in run_to_breakpoint_do_run
      test.assertEqual(process.GetState(), lldb.eStateStopped)
  AssertionError: 10 != 5
  Config=x86_64-/usr/local/google/home/blaikie/dev/llvm/build/release/bin/clang
  ======================================================================
  FAIL: test_ref_and_ptr_dwo (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase)
     Test that the data formatters work on ref and ptr.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1823, in test_method
      return attrvalue(self)
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/set/TestDataFormatterLibcxxSet.py", line 128, in test_ref_and_ptr
      (self.target, process, _, bkpt) = lldbutil.run_to_source_breakpoint(
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/packages/Python/lldbsuite/test/lldbutil.py", line 970, in run_to_source_breakpoint
      return run_to_breakpoint_do_run(test, target, breakpoint, launch_info,
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/packages/Python/lldbsuite/test/lldbutil.py", line 892, in run_to_breakpoint_do_run
      test.assertEqual(process.GetState(), lldb.eStateStopped)
  AssertionError: 10 != 5
  Config=x86_64-/usr/local/google/home/blaikie/dev/llvm/build/release/bin/clang
  ======================================================================
  FAIL: test_with_run_command_dwarf (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase)
     Test that that file and class static variables display correctly.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1823, in test_method
      return attrvalue(self)
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/set/TestDataFormatterLibcxxSet.py", line 49, in test_with_run_command
      (self.target, process, _, bkpt) = lldbutil.run_to_source_breakpoint(
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/packages/Python/lldbsuite/test/lldbutil.py", line 970, in run_to_source_breakpoint
      return run_to_breakpoint_do_run(test, target, breakpoint, launch_info,
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/packages/Python/lldbsuite/test/lldbutil.py", line 892, in run_to_breakpoint_do_run
      test.assertEqual(process.GetState(), lldb.eStateStopped)
  AssertionError: 10 != 5
  Config=x86_64-/usr/local/google/home/blaikie/dev/llvm/build/release/bin/clang
  ======================================================================
  FAIL: test_with_run_command_dwo (TestDataFormatterLibcxxSet.LibcxxSetDataFormatterTestCase)
     Test that that file and class static variables display correctly.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1823, in test_method
      return attrvalue(self)
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/set/TestDataFormatterLibcxxSet.py", line 49, in test_with_run_command
      (self.target, process, _, bkpt) = lldbutil.run_to_source_breakpoint(
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/packages/Python/lldbsuite/test/lldbutil.py", line 970, in run_to_source_breakpoint
      return run_to_breakpoint_do_run(test, target, breakpoint, launch_info,
    File "/usr/local/google/home/blaikie/dev/llvm/src/lldb/packages/Python/lldbsuite/test/lldbutil.py", line 892, in run_to_breakpoint_do_run
      test.assertEqual(process.GetState(), lldb.eStateStopped)
  AssertionError: 10 != 5
  Config=x86_64-/usr/local/google/home/blaikie/dev/llvm/build/release/bin/clang
  ----------------------------------------------------------------------
  Ran 8 tests in 3.109s

  RESULT: FAILED (0 passes, 4 failures, 0 errors, 4 skipped, 0 expected failures, 0 unexpected successes)

  --

Any ideas?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111981/new/

https://reviews.llvm.org/D111981