[Lldb-commits] [PATCH] D111989: [lldb] Reduce code duplication around inferior building

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 18 05:49:10 PDT 2021


labath created this revision.
labath added reviewers: teemperor, JDevlieghere.
labath requested review of this revision.
Herald added a project: LLDB.

We had two sets of build<flavour> methods, whose bodies were largely
identical. This makes any kind of modification in their vicinity
repetitive and error-prone.

Replace each set with a single method taking an optional debug_info
parameter.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111989

Files:
  lldb/docs/testsuite/a-detailed-walkthrough.txt
  lldb/packages/Python/lldbsuite/test/README-TestSuite
  lldb/packages/Python/lldbsuite/test/builders/builder.py
  lldb/packages/Python/lldbsuite/test/builders/darwin.py
  lldb/packages/Python/lldbsuite/test/lldbtest.py
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
  lldb/test/API/commands/add-dsym/uuid/TestAddDsymCommand.py
  lldb/test/API/functionalities/breakpoint/comp_dir_symlink/TestCompDirSymLink.py
  lldb/test/API/functionalities/unwind/standard/TestStandardUnwind.py
  lldb/test/API/macosx/add-dsym/TestAddDsymDownload.py
  lldb/test/API/macosx/add-dsym/TestAddDsymMidExecutionCommand.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111989.380357.patch
Type: text/x-patch
Size: 24094 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211018/d73e55be/attachment-0001.bin>


More information about the lldb-commits mailing list