[Lldb-commits] [PATCH] D111963: [lldb] [lldb-server] Refactor ConnectToRemote()

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 18 00:50:43 PDT 2021


labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:218
                       "(connection status: %d)\n",
-              connection_url, static_cast<int>(connection_result));
-      exit(-1);
-    }
-    if (error.Fail()) {
-      fprintf(stderr, "error: failed to connect to client at '%s': %s\n",
-              connection_url, error.AsCString());
+              connection_url.c_str(), static_cast<int>(connection_result));
       exit(-1);
----------------
maybe replace with llvm::errs(), while you're in there?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111963/new/

https://reviews.llvm.org/D111963



More information about the lldb-commits mailing list