[Lldb-commits] [PATCH] D111491: [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack

[Michał Górny via Phabricator via lldb-commits]

mgorny added a comment.

Ehh, it seems that we have 4 tests that abuse this to avoid having to pass the register infos:

  FAIL: LLDB (/home/mgorny/git/llvm-project/build/bin/clang-x86_64) :: test_read_registers_using_g_packets (TestGDBRemoteClient.TestGDBRemoteClient)
  FAIL: LLDB (/home/mgorny/git/llvm-project/build/bin/clang-x86_64) :: test_read_registers_using_p_packets (TestGDBRemoteClient.TestGDBRemoteClient)
  FAIL: LLDB (/home/mgorny/git/llvm-project/build/bin/clang-x86_64) :: test_write_registers_using_G_packets (TestGDBRemoteClient.TestGDBRemoteClient)
  FAIL: LLDB (/home/mgorny/git/llvm-project/build/bin/clang-x86_64) :: test_write_registers_using_P_packets (TestGDBRemoteClient.TestGDBRemoteClient)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111491/new/

https://reviews.llvm.org/D111491