[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 8 09:18:42 PDT 2021


mib added a comment.

In D111409#3051556 <https://reviews.llvm.org/D111409#3051556>, @d-millar wrote:

> Hmmm, well, have tried running "git clang-format" with a few different invocations, but seem to always get "No modified files to format."  Suggestions?

I was confused by the `patch` file, since it included the entire `SBDebugger.cpp`, I thought you were adding all that code.
Since clang-format mostly cares about C/Objective-C/C++ files, I guess you're fine with the formatting.  However, it looks like the `patch` file is still here.

To remove it from the diff, make sure you delete it from your local repository, add all your changes to the git index (`git add <changes>`) and make a commit. Then, create your new patch (`git show HEAD -U999999 > mypatch.patch`) and update the differential by uploading the new patch (`mypatch.patch`). While doing so, you can review your changes and make sure you didn't included the `patch` file in the differential.

Thanks!


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111409/new/

https://reviews.llvm.org/D111409



More information about the lldb-commits mailing list