[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 8 08:12:19 PDT 2021


mib added a comment.

In D111409#3051140 <https://reviews.llvm.org/D111409#3051140>, @d-millar wrote:

> Am obviously brand new to your process and a bit of an old dog when it comes to learning new tricks.  Would you prefer I make a new submission with the -U999999 diff?   Also, am more than willing to help with the Java tests if that would be useful.

Hi @d-millar,

Here are some ressources that will help you comply with the LLVM guidelines:

- Contributing to LLVM : https://llvm.org/docs/Contributing.html
- Code Reviews with Phabricator : https://llvm.org/docs/Phabricator.html

Do you mind updating this diff by removing the patch and running clang-format on your code ?

That would simplify code review for reviewers.

Thanks!


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111409/new/

https://reviews.llvm.org/D111409



More information about the lldb-commits mailing list