[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

In D111409#3051110 <https://reviews.llvm.org/D111409#3051110>, @d-millar wrote:

> Apologies for the inclusion of that last file "patch" - that is the "git diff -U9999999" result, should that be useful.

You can just upload that diff file and Phabricator will display it properly. There is no need to include the raw diff as part of the patch itself (it just makes this diff 100 times larger than it needs to be) :)

Anyway, I think this seems like a reasonable thing to have. We have to figure out though how we can properly set up some Java tests for this and it would be nice if we also find a bot that could actually run the tests for us.



================
Comment at: lldb/bindings/java/CMakeLists.txt:3
+ * IP: Apache License 2.0 with LLVM Exceptions
+ */
+add_custom_command(
----------------
I don't think CMake accepts this as a comment and I think we anyway don't put license headers in CMake scripts.


================
Comment at: lldb/source/API/CMakeLists.txt:84
   SBTrace.cpp
+  SBTraceOptions.cpp
   SBType.cpp
----------------
I think this is some conflict with one of the SBTrace patches.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111409/new/

https://reviews.llvm.org/D111409