[Lldb-commits] [PATCH] D111314: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile

Fri Oct 8 01:31:32 PDT 2021

labath added a comment.

In D111314#3050392 <https://reviews.llvm.org/D111314#3050392>, @mgorny wrote:

> In D111314#3050383 <https://reviews.llvm.org/D111314#3050383>, @labath wrote:
>
>> At one point these didn't use to be shared pointers so we couldn't copy them like this, though I am still unclear as to why we need two of them in the first place.
>
> Actually, I've asked you on IRC yesterday if you think I should replace them with one field, or if we should keep the separate semantics for some possible use in the future.

Yeah, and I don't really know the answer to that.

But if you make a patch to merge the two,  I'll probably approve it. :)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111314/new/

https://reviews.llvm.org/D111314