[Lldb-commits] [PATCH] D111278: Recognize the Swift compiler in DW_AT_producer

Thu Oct 7 12:52:33 PDT 2021

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:684
+  llvm::SmallVector<llvm::StringRef, 3> matches;
+  if (g_swiftlang_version_regex.Execute(producer, &matches)) {
+      m_producer_version.tryParse(matches[1]);
----------------
aprantl wrote:
> JDevlieghere wrote:
> > For consistency with the code below, should we first check if `roducer.contains("swift")` and then execute the regex? Otherwise the indentation on the line below is off. 
> I think it makes more sense to run the clang regex right away. Matching the regex is faster than first searching for clang and then running the regex.
Sounds reasonable to me. Should we do the same for clang? Then we just need to fix the indentation on line 685.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111278/new/

https://reviews.llvm.org/D111278